Use ksni on linux #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I'd like to see the old implementation still available under a feature flag since ksni does not work in all environments. |
|
Doesn't libappindicator use the same dbus SNI interface internally to show the tray icon? |
|
@ancwrd1 It does not work when using Waybar. Old impl: New impl: Well, it does work but the icon is missing, space is allocated, hint and click actions work just fine. Sorry for the extremely late reply. |
|
@njust I ran the linux example. It uses a "named icon" instead of a gresource icon. |
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I updated the linux implementation to use ksni as discussed in #2. I tested it on linux Mint 20.1.